Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions charts/temporal/templates/server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,16 @@ spec:
tcpSocket:
port: rpc
{{- end }}
{{- if or (eq $service "frontend") (eq $service "internal-frontend") }}
readinessProbe:
grpc:
port: {{ $serviceValues.service.port }}
service: temporal.api.workflowservice.v1.WorkflowService
{{- else }}
Comment thread
quangngotan95 marked this conversation as resolved.
Outdated
{{- with default $.Values.server.readinessProbe $serviceValues.readinessProbe }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
volumeMounts:
- name: config
mountPath: /etc/temporal/config/config_template.yaml
Expand Down
47 changes: 47 additions & 0 deletions charts/temporal/tests/server_deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,50 @@ tests:
- equal:
path: spec.strategy.rollingUpdate.maxUnavailable
value: 0
- it: readinessProbe defaults to empty
template: templates/server-deployment.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-worker")].kind'
value: Deployment
matchMany: true
asserts:
- notExists:
path: spec.template.spec.containers[0].readinessProbe
- it: readinessProbe is set for frontend service
template: templates/server-deployment.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
value: Deployment
matchMany: true
set:
server:
frontend:
service:
port: 9999
asserts:
- equal:
path: spec.template.spec.containers[0].readinessProbe.grpc.port
value: 9999
- equal:
path: spec.template.spec.containers[0].readinessProbe.grpc.service
value: temporal.api.workflowservice.v1.WorkflowService
- it: readinessProbe is set for history service
template: templates/server-deployment.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-history")].kind'
value: Deployment
matchMany: true
set:
server:
history:
readinessProbe:
initialDelaySeconds: 300
tcpSocket:
port: rpc
asserts:
- equal:
path: spec.template.spec.containers[0].readinessProbe.initialDelaySeconds
value: 300
- equal:
path: spec.template.spec.containers[0].readinessProbe.tcpSocket.port
value: rpc
12 changes: 12 additions & 0 deletions charts/temporal/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ server:
pullPolicy: IfNotPresent
# Global default settings (can be overridden per service)
replicaCount: 1
readinessProbe: {}
metrics:
# Annotate pods and services directly with the following Prometheus annotations.
# prometheus.io/job
Expand Down Expand Up @@ -229,6 +230,10 @@ server:
membershipAppProtocol: tcp
httpPort: 7243
httpAppProtocol: http
readinessProbe:
grpc:
port: 7233
service: temporal.api.workflowservice.v1.WorkflowService
ingress:
enabled: false
# className:
Expand Down Expand Up @@ -277,6 +282,10 @@ server:
membershipAppProtocol: tcp
httpPort: 7246
httpAppProtocol: http
readinessProbe:
grpc:
port: 7236
service: temporal.api.workflowservice.v1.WorkflowService
metrics:
annotations:
enabled: true
Expand Down Expand Up @@ -304,6 +313,7 @@ server:
appProtocol: tcp
membershipPort: 6934
membershipAppProtocol: tcp
readinessProbe: {}
metrics:
annotations:
enabled: true
Expand Down Expand Up @@ -332,6 +342,7 @@ server:
appProtocol: tcp
membershipPort: 6935
membershipAppProtocol: tcp
readinessProbe: {}
metrics:
annotations:
enabled: false
Expand Down Expand Up @@ -359,6 +370,7 @@ server:
appProtocol: tcp
membershipPort: 6939
membershipAppProtocol: tcp
readinessProbe: {}
metrics:
annotations:
enabled: true
Expand Down