Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/temporal/templates/server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ spec:
topologySpreadConstraints:
{{- toYaml . | nindent 8 }}
{{- end }}
terminationGracePeriodSeconds: {{ default $.Values.server.terminationGracePeriodSeconds $serviceValues.terminationGracePeriodSeconds }}
---
{{- end }}
{{- end }}
Expand Down
25 changes: 25 additions & 0 deletions charts/temporal/tests/server_deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,31 @@ tests:
- equal:
path: spec.minReadySeconds
value: 30
- it: terminationGracePeriodSeconds is null by default
template: templates/server-deployment.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
value: Deployment
matchMany: true
asserts:
- equal:
path: spec.template.spec.terminationGracePeriodSeconds
value: null
- it: terminationGracePeriodSeconds favors service specific resources
template: templates/server-deployment.yaml
documentSelector:
path: '$[?(@.metadata.name == "RELEASE-NAME-temporal-frontend")].kind'
value: Deployment
matchMany: true
set:
server:
terminationGracePeriodSeconds: 30
frontend:
terminationGracePeriodSeconds: 60
asserts:
- equal:
path: spec.template.spec.terminationGracePeriodSeconds
value: 60
- it: renders log config with defaults
template: templates/server-configmap.yaml
asserts:
Expand Down
1 change: 1 addition & 0 deletions charts/temporal/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ server:
tolerations: []
affinity: {}
minReadySeconds: 0
terminationGracePeriodSeconds: null
additionalVolumes: []
additionalVolumeMounts: []
additionalEnv: []
Expand Down