Allow setting other config values in metrics#834
Merged
robholland merged 3 commits intotemporalio:mainfrom Jan 27, 2026
Merged
Conversation
Contributor
|
Please create |
Contributor
|
We don't need to handle backwards compatibility here as we're heading to a new major release. Let's drop the complexity as we have the opportunity to clean up the confusing setup. |
robholland
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Allow setting other metrics fields in config template.
Move the configuration related metrics field from
server.metricstoserver.config.metricsWhy?
Add
server.config.metricswhich is used to generate metrics section for config for consistency with other configuration related data.Default value of prometheus configuration has been moved to values.yaml.
Checklist
Closes
How was this tested:
Tested the full template by printing out various combinations. Verified no diff with default values.
Might be need to mention in breaking changes section of v1.