Skip to content

Allow setting other config values in metrics#834

Merged
robholland merged 3 commits intotemporalio:mainfrom
ntnj:metrics-config
Jan 27, 2026
Merged

Allow setting other config values in metrics#834
robholland merged 3 commits intotemporalio:mainfrom
ntnj:metrics-config

Conversation

@ntnj
Copy link
Copy Markdown
Contributor

@ntnj ntnj commented Jan 17, 2026

What was changed

Allow setting other metrics fields in config template.

Move the configuration related metrics field from server.metrics to server.config.metrics

Why?

Add server.config.metrics which is used to generate metrics section for config for consistency with other configuration related data.
Default value of prometheus configuration has been moved to values.yaml.

Checklist

  1. Closes

  2. How was this tested:

Tested the full template by printing out various combinations. Verified no diff with default values.

  1. Any docs updates needed?

Might be need to mention in breaking changes section of v1.

@ntnj ntnj requested a review from a team as a code owner January 17, 2026 18:27
@robholland
Copy link
Copy Markdown
Contributor

Please create server.config.metrics as you suggest, now is a good time to make such a change.

@robholland robholland added the needs revision Team has requested some changes label Jan 21, 2026
@robholland
Copy link
Copy Markdown
Contributor

We don't need to handle backwards compatibility here as we're heading to a new major release. Let's drop the complexity as we have the opportunity to clean up the confusing setup.

@robholland robholland removed the needs revision Team has requested some changes label Jan 27, 2026
@robholland robholland merged commit 18e0fe4 into temporalio:main Jan 27, 2026
4 checks passed
@ntnj ntnj deleted the metrics-config branch January 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants