feat: add support for secondary visibility store (dual visibility)

[ignaciogonzalezsomoza]

Summary

This PR adds support for secondaryVisibilityStore configuration to enable the dual visibility feature in Temporal server. This allows writing to two visibility stores simultaneously, which is useful for migration scenarios (e.g., migrating from Cassandra to Elasticsearch for visibility).

Changes

• _helpers.tpl:
  • Added secondaryVisibilityStore support in temporal.persistence.filterConfig function
  • Updated temporal.persistence.eachStore to include secondary visibility store in iteration
• server-deployment.yaml:
  • Added TEMPORAL_SECONDARY_VISIBILITY_STORE_PASSWORD environment variable to server pods
  • Added conditional logic to inject the env var only when secondaryVisibilityStore is configured
• Tests:
  • Added unit tests for ConfigMap generation with secondary visibility store
  • Added unit tests for environment variable injection

Implementation Details

This implementation leverages the V1 chart architecture's centralized helper functions, avoiding the code duplication present in PR #803 (which targeted v0.x). The key improvements:

1. Single source of truth: All persistence configuration flows through temporal.persistence.filterConfig
2. Automatic propagation: Schema jobs and deployments automatically process the secondary store via temporal.persistence.eachStore
3. Backward compatible: Charts without secondaryVisibilityStore configured continue to work as before

Testing

Tested in a development cluster with:

• Primary visibility store: Elasticsearch v8 (temporal_visibility_v1_dev)
• Secondary visibility store: Elasticsearch v8 (temporal_visibility_v1_dev_readonly)

Verified that:

• ConfigMap contains both visibility stores
• Environment variables are injected correctly
• Pods start successfully
• Workflows are written to both indices simultaneously
• Schema jobs process secondary visibility store
• Unit tests pass

Related

Closes #803

This PR adapts the changes from #803 to the V1 chart structure, making them compatible with the refactored architecture introduced in the V1 release.

Documentation

Example configuration:

server:
  config:
    persistence:
      defaultStore: default
      visibilityStore: visibility
      secondaryVisibilityStore: secondary-visibility  # New
      datastores:
        default:
          sql: ...
        visibility:
          elasticsearch: ...
        secondary-visibility:  # New secondary store
          elasticsearch:
            version: v8
            indices:
              visibility: temporal_visibility_readonly
            # ... other ES config

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[robholland]

Looks good, please resolve conflicts and then I can get this merged.

[robholland]

Hey @ignaciogonzalezsomoza, please could you merge main, then I can get your PR merged :)

[ignaciogonzalezsomoza]

Fixed the failing test in commit 046312f. The secret name was missing the temporal- prefix.
Ready to merge once CI passes.

[robholland]

🎉