Add TLS configuration support for Elasticsearch visibility store#862
Merged
robholland merged 2 commits intotemporalio:mainfrom Mar 25, 2026
Merged
Add TLS configuration support for Elasticsearch visibility store#862robholland merged 2 commits intotemporalio:mainfrom
robholland merged 2 commits intotemporalio:mainfrom
Conversation
The `temporal-elasticsearch-tool` binary supports TLS env vars (ES_TLS, ES_TLS_CA_FILE, ES_TLS_CERT_FILE, ES_TLS_KEY_FILE, ES_TLS_SERVER_NAME, ES_TLS_DISABLE_HOST_VERIFICATION) but the chart never sets them, unlike the Cassandra and SQL drivers which already have full TLS support in _admintools-env.yaml. This causes init containers (check-elasticsearch-index, setup-visibility-store) to fail with x509 certificate errors when connecting to Elasticsearch clusters with self-signed or custom CA certificates. This commit adds the same tls config block pattern used by Cassandra and SQL to the Elasticsearch section, mapping: tls.enabled -> ES_TLS tls.caFile -> ES_TLS_CA_FILE tls.certFile -> ES_TLS_CERT_FILE tls.keyFile -> ES_TLS_KEY_FILE tls.serverName -> ES_TLS_SERVER_NAME tls.enableHostVerification -> ES_TLS_DISABLE_HOST_VERIFICATION (inverted) Made-with: Cursor
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Contributor
|
This changes make sense to me. Could you add some tests under charts/temporal/tests/admintools_deployment_test.yaml? |
Tests verify that ES TLS env vars (ES_TLS, ES_TLS_CA_FILE, ES_TLS_CERT_FILE, ES_TLS_KEY_FILE, ES_TLS_SERVER_NAME, ES_TLS_DISABLE_HOST_VERIFICATION) are correctly rendered in the server-job init containers via _admintools-env.yaml. Covers full TLS config, minimal config (enabled only), and enableHostVerification boolean inversion logic. Made-with: Cursor
Contributor
Author
|
@yux0 added the tests for |
yux0
approved these changes
Mar 25, 2026
Contributor
|
@adamovittorio Stamped the changes. Thank you very much for the contribution! |
Contributor
Author
|
I'm unable to merge the changes, and a workflow is waiting for a maintainer's approval. Thank you @yux0 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
temporal-elasticsearch-toolbinary supports a full set of TLS environment variables (ES_TLS,ES_TLS_CA_FILE,ES_TLS_CERT_FILE,ES_TLS_KEY_FILE,ES_TLS_SERVER_NAME,ES_TLS_DISABLE_HOST_VERIFICATION), but the chart's_admintools-env.yamlhelper never sets them for the Elasticsearch driver. Both Cassandra and SQL drivers already have full TLS support in this helper.This causes init containers (
check-elasticsearch-index,setup-visibility-store) to fail withx509: certificate signed by unknown authorityerrors when connecting to Elasticsearch clusters with self-signed or custom CA certificates.Changes
_admintools-env.yaml: Addedtlsconfig block to the Elasticsearch section, following the same pattern as SQL:tls.enabled→ES_TLStls.caFile→ES_TLS_CA_FILEtls.certFile/tls.keyFile→ES_TLS_CERT_FILE/ES_TLS_KEY_FILEtls.serverName→ES_TLS_SERVER_NAMEtls.enableHostVerification→ES_TLS_DISABLE_HOST_VERIFICATION(inverted, consistent with Cassandra/SQL)values.yaml: Added commented TLS example to the Elasticsearch configuration blockvalues/values.elasticsearch.yaml: Added commented TLS exampleExample usage
Related
tools/elasticsearch/README.mdMade with Cursor