Backports the fix for broadcastAddress interpolation from the v1.x-rc…#864
Merged
robholland merged 1 commit intotemporalio:v0.xfrom Apr 1, 2026
Merged
Conversation
|
|
|
This is the best change I have ever seen 🤩 @GBlodgett35 |
robholland
approved these changes
Mar 30, 2026
Author
|
Hey @robholland thanks for approving my MR! What are the next steps to getting this merged and a new stable release of the helm chart deployed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Wraps the environment variable in quotes using the | quote helper. This ensures the IP is treated as a string regardless of its format. This was already done in the -rc branch, so I am backporting this to the stable branch: https://github.com/temporalio/helm-charts/blob/temporal-1.0.0-rc.2/charts/temporal/templates/server-configmap.yaml#L33
Why?
In IPv6 clusters, POD_IP can contain trailing double-colons (e.g., 2600:...::). When dockerize interpolates this into the YAML without quotes, the YAML parser fails with mapping values are not allowed in this context.
Checklist
Closes [Bug] Temporal Frontend deployment cannot start in IPv6 clusters #824
How was this tested:
Running:
yields:
To show the error I have created a local file:
And ran a docker image:
Which yields the error:
And after changing the file to a slightly different version (Since env is a helm specific tool):
I now get:
None.