Skip to content

fix: pass admintools.additionalEnv to create-store and manage-schema containers (#865)#874

Merged
robholland merged 1 commit intomainfrom
jiechenz/fix/865-admintools-env
Apr 2, 2026
Merged

fix: pass admintools.additionalEnv to create-store and manage-schema containers (#865)#874
robholland merged 1 commit intomainfrom
jiechenz/fix/865-admintools-env

Conversation

@jiechenz
Copy link
Copy Markdown
Contributor

@jiechenz jiechenz commented Apr 1, 2026

What was changed

This change added additionalEnv, additionalEnvSecretName, and additionalEnvConfigMapName support to the create-*-store and manage-schema-*-store init containers in server-job.yaml.

Before the change these were only passed to the create-*-namespace containers.

Updated unit tests to assert that additional env are present on all init container types.

Why?

Bug fix: Environment variables set via admintools.additionalEnv are not inherited by the create-default-store, setup-default-store, and update-default-store init containers.

Checklist

  1. Closes [Bug] admintools.additionalEnv not being passed to create/manage-schema containers #865

  2. How was this tested:
    Updated helm unittest test case "includes additional environment variables" in server_job_test.yaml to cover all init container types

  3. Any docs updates needed?
    Bug fix, README already covers this feature.

@jiechenz jiechenz requested a review from a team as a code owner April 1, 2026 17:04
@robholland robholland merged commit 51e7f60 into main Apr 2, 2026
3 checks passed
@robholland robholland deleted the jiechenz/fix/865-admintools-env branch April 2, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] admintools.additionalEnv not being passed to create/manage-schema containers

2 participants