Update server-service.yaml

[iamhritik]

What was changed

Added a conditional check to only create the 'internalFrontend' service when 'internalFrontend.enabled: true' in values. The service list is now dynamically constructed instead of always iterating over both 'frontend' and 'internalFrontend'.

Why?

Previously, the template always created Service resources for both 'frontend' and 'internalFrontend' regardless of their enabled status. This resulted in unnecessary/invalid service resources when 'internalFrontend.enabled: false'. The fix ensures services are only created when explicitly enabled.

How was this changed

# Before: Always iterates over both services
{{- range $rawService := (list "frontend" "internalFrontend") }}
# After: Dynamically builds list based on enabled flags
{{- $services := list "frontend" }}
{{- if $.Values.server.internalFrontend.enabled }}
{{-   $services = concat $services (list "internalFrontend") }}
{{- end }}
{{- range $rawService := $services }}

Checklist

1. Closes
2. How was this tested:
   Ran helm template . between main and this branch, and verified that only diff is this config.
3. Any docs updates needed?

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[robholland]

We already check .enabled for the services and there are tests covering this case: https://github.com/temporalio/helm-charts/pull/877/changes#diff-486a112e02d2716ae96ff167bf2ab4117023c57043a9a1a6a76325e0a00560b9L4.

The reason you are seeing this behaviour is a stale values file that has "internalFrontend" key instead of "internal-frontend". I will add a validation to help people spot this and add a note to UPGRADING.md.