Skip to content

Omit Elasticsearch cluster settings #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuart-wells merged 5 commits into from
Apr 29, 2026
+1 −1
Merged

Omit Elasticsearch cluster settings #901

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
328d956
Option to skip cluster setting w/ Elasticsearch
Apr 27, 2026
b2c4e23
Updating Readme to include new setting
Apr 27, 2026
b57d6dc
Removing new setting and setup-schema usage
Apr 28, 2026
8322eb8
remove tests
Apr 29, 2026
94be6c7
testing empty index
Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/temporal/templates/server-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ spec:
{{- fail (printf "manageSchema is not supported for %s SQL database plugin" $store.config.pluginName) -}}
{{- end }}
{{- else if eq $store.driver "elasticsearch" }}
- temporal-elasticsearch-tool setup-schema && temporal-elasticsearch-tool create-index && temporal-elasticsearch-tool update-schema --index "$ES_VISIBILITY_INDEX"
- temporal-elasticsearch-tool update-schema && temporal-elasticsearch-tool create-index && temporal-elasticsearch-tool update-schema --index "$ES_VISIBILITY_INDEX"
{{- end }}
env:
{{- include "temporal.admintools-env" (list $ $store) | nindent 12 }}
Expand Down
50 changes: 50 additions & 0 deletions charts/temporal/tests/server_job_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,3 +585,53 @@ tests:
- equal:
path: spec.template.spec.initContainers[?(@.name=="manage-schema-default-store")].env[?(@.name=="SQL_PORT")].value
value: "5432"
- it: does not use setup-schema for elasticsearch
Copy link
Copy Markdown
Contributor

@robholland robholland Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right layer to test this, you can drop the tests.

set:
server:
config:
persistence:
datastores:
default:
sql:
pluginName: mysql8
connectAddr: "temporal-persistence:3306"
databaseName: temporal
visibility:
elasticsearch:
version: v7
url:
scheme: http
host: "elasticsearch:9200"
username: ""
password: ""
indices:
visibility: temporal_visibility_v1
asserts:
- notMatchRegex:
path: spec.template.spec.initContainers[?(@.name=="manage-schema-visibility-store")].args[0]
pattern: "setup-schema"
- it: uses update-schema and create-index for elasticsearch
set:
server:
config:
persistence:
datastores:
default:
sql:
pluginName: mysql8
connectAddr: "temporal-persistence:3306"
databaseName: temporal
visibility:
elasticsearch:
version: v7
url:
scheme: http
host: "elasticsearch:9200"
username: ""
password: ""
indices:
visibility: temporal_visibility_v1
asserts:
- matchRegex:
path: spec.template.spec.initContainers[?(@.name=="manage-schema-visibility-store")].args[0]
pattern: "update-schema && temporal-elasticsearch-tool create-index && temporal-elasticsearch-tool update-schema --index"
Loading