Sanitize schema job names for chart build metadata#902
Merged
robholland merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
robholland
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Sanitized the schema and namespace job names so chart versions with semver build metadata render valid Kubernetes job names. Added regression tests covering
Chart.Versionvalues that contain+.Why?
When the chart is deployed from a packaged version like
1.1.1+build, that+was included in job names. Kubernetes job names cannot contain+, so installs via FluxCD could fail. This change normalizes that character to-.Checklist
Closes [Bug] Job name is invalid in k8s #899
How was this tested:
helm unittest -f tests/server_job_test.yaml -f tests/server_namespace_job_test.yaml .Any docs updates needed?
n/a