feat: add global.imageRegistry support - #968
Open
katieg12345 wants to merge 1 commit into
Open
Conversation
When we want to use a different registry than Docker Hub we currently
have to override each image repository individually:
```yaml
server:
image:
repository: registry.example.com/temporalio/server
admintools:
image:
repository: registry.example.com/temporalio/admin-tools
web:
image:
repository: registry.example.com/temporalio/ui
```
This requires duplicating the registry in multiple places. This change
adds a global registry setting so the same result is achieved with:
```yaml
global:
imageRegistry: registry.example.com
```
This becomes especially useful when the Temporal chart is used as a
dependency in another chart. When all sub-charts honour
global.imageRegistry the installer only has to set the registry once.
This change is non-breaking and backwards compatible. If
global.imageRegistry is not set the chart behaves exactly as before.
|
|
yardenshoham
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds support for configuring a global image registry via:
When set, this value is used as a prefix for all Temporal chart container images.
When unset/empty, image rendering remains unchanged from current behavior.
Why?
Today, using a private/mirrored registry requires overriding multiple repositories separately, which is repetitive and error-prone.
A global registry setting is a common Helm pattern and simplifies installation, especially for air-gapped/private registry environments/dependency-chart use-cases where we'd want one registry override in one place
This change is backward-compatible and non-breaking:
if global.imageRegistry is not set, behavior is exactly as before.
Checklist
Closes [Feature Request] Support global.imageRegistry in temporal chart #967
How was this tested:
Helm unit tests:
helm unittest charts/temporal
Result: all suites pass (15/15), all tests pass (188/188)
Render checks with valid chart values:
Without global.imageRegistry: images render as current defaults (temporalio/...)
With global.imageRegistry=registry.example.com: all chart images render with registry.example.com/ prefix
Any docs updates needed?
values.yaml was updated to include and describe global.imageRegistry.
A README values table update could be added as a follow-up.