Conversation
THardy98
force-pushed
the
feat/go-harness
branch
from
368cdd7 to
b4cc801
Compare
THardy98
force-pushed
the
feat/go-harness
branch
from
be9b5cc to
9205dbc
Compare
Sushisource
reviewed
Apr 28, 2026
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Am I missing where there's a Go test project?
Contributor
Author
Adding in a subsequent PR. Wanted to separate the harness implementation and the actual (this applies for the other harness PRs as well for TS and Ruby) |
Sushisource
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds
go/harness/package, effectively a port of the same Python harness (python/harness).go/harnesssupports the same harness semantics, structure, and API as the existing Python harness. The test suite (project_test.goandworker_test.go) similarly mimic the existing Python harness test suite.The Go worker uniquely supported additional flags for worker deployment versioning that were not available/used in other languages, that has correspondingly been added to the Go's worker harness.
Note: in contrast to the harness in other languages, the Go harness is not a standalone Go module. There is significant coupling between the existing go worker code and Omes which would make this either a much larger change, or cause a lot of duplication. The plan is to use the existing
workers/go/go.modas a single source to manage dependencies between the harness and the tests that consume it (at least, until this is resolved)Why?