Skip to content

Update to metrics sample#197

Open
tsurdilo wants to merge 3 commits into
temporalio:mainfrom
tsurdilo:updatemetricssample
Open

Update to metrics sample#197
tsurdilo wants to merge 3 commits into
temporalio:mainfrom
tsurdilo:updatemetricssample

Conversation

@tsurdilo

@tsurdilo tsurdilo commented May 2, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tihomir Surdilovic tihomir@temporal.io

  • adds how to add custom metric in workflow code
  • adds how to set custom tags
  • updates worker to publish metrics on port 9092 (default server metrics are exposed on port 9090 so this way it wont clash).

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Comment thread metrics/worker/main.go Outdated
SanitizeOptions: &sanitizeOptions,
Prefix: "temporal_samples",
Tags: map[string]string{"my_key1": "my_value1",
"my_key2": "my_value2"},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run go fmt on this file. All Go IDEs should do this automatically for you on save.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cretz done

tsurdilo added 2 commits May 8, 2022 21:41
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
@cretz

cretz commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

@tsurdilo - Should we still merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants