Skip to content

add errgroup sample#198

Open
jackielii wants to merge 2 commits into
temporalio:mainfrom
jackielii:errgroup
Open

add errgroup sample#198
jackielii wants to merge 2 commits into
temporalio:mainfrom
jackielii:errgroup

Conversation

@jackielii

@jackielii jackielii commented May 10, 2022

Copy link
Copy Markdown

What was changed

add errgroup sample

Why?

errgroup synchronise cancellation is a common pattern.

Checklist

  1. How was this tested:

go run errgroup/errgroup.go

  1. Any docs updates needed?

No other updates needed. Added README.md

@CLAassistant

CLAassistant commented May 10, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cretz

cretz commented May 16, 2022

Copy link
Copy Markdown
Contributor

Thanks! Can I make a few requests? Firstly, can you split into the starter and worker CLI off as we do in other samples? Second, can you update the root repo README to point to this sample? Finally, can you add a test? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants