Change all samples to use envconfig to connect to client #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 4, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks great to me, but refraining from marking approve because there is talk of waiting until the env config feature is in a further-along release stage.
Contributor
Author
|
Env conf is entering the next release stage soon, we should be okay to merge this in now |
THardy98
approved these changes
Nov 7, 2025
Contributor
Approving because we're there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: Let's not merge this until env config gets past pre-release and is implemented in all other languages
What was changed
Use envconfig
Why?
allow setting env variables by default when running samples
Checklist
Closes [Feature Request] Environment configuration #390
How was this tested: