-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require frozenlist to update version #107
Conversation
|
Can you give more details? Our CI passes on Windows 3.12, here's the latest: https://github.com/temporalio/samples-python/actions/runs/7977279807/job/21779816371. Is there some test we could write that would make CI fail if this fix wasn't in place? |
Yeah, it was triggering this PEP 517 build error in a relatively stock environment: My knowledge of Python bootstrapping is somewhat out of date -- it's possible our build system is doing something different than my environment to make the build pass -- but updating the dependency to a supported version that has wheels available seemed like a decent idea regardless. |
Also -- this was only occurring when doing |
Sure, but I want to make sure we catch future issues like this too, but if our build environment is not representative in some way I think we should fix.
👍 So I wonder if we should add |
Done! I strongly suspect that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly suspect that the ci.yml change would not work without the pyproject.toml change -- let me know if you'd like me to verify this further before merging.
Good enough for me! Merge at will.
add
frozenlist = "^1.4.0"
to dev-dependencies since this was trying to install an older version that wasn't building right under Python 3.12 / MSVC 2022