Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic samples to use contrib module #163

Merged
merged 16 commits into from
Feb 19, 2025
Merged

Update pydantic samples to use contrib module #163

merged 16 commits into from
Feb 19, 2025

Conversation

dandavison
Copy link
Contributor

To merge once temporalio/sdk-python#757 is released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer a pydantic_converter_v1 sample instead of putting inside another sample

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1's a thing of the past. I think that pollutes the top-level namespace unnecessarily.

Copy link
Member

@cretz cretz Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's easier to ignore a top-level sample you don't care about than code inside a sample you do. This looks like v1 is a subdir/module of the pydantic_converter sample, not its own sample. Subdirs of Python code are usually considered modules of that code, not separate/unrelated (and this has been the case in samples thus far).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK you're probably right about the structure. But let's delete it at some point -- when we do we can always leave a permalink to the content in git history in the remaining README of the v2 sample.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would move this to tests/pydantic_converter_v1 dir

@dandavison dandavison marked this pull request as draft February 19, 2025 17:01
@dandavison dandavison marked this pull request as ready for review February 19, 2025 17:20
@dandavison dandavison merged commit 3bd017d into main Feb 19, 2025
11 checks passed
@dandavison dandavison deleted the pydantic branch February 19, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants