Migrate to uv #170

dandavison · 2025-03-31T14:41:55Z

Switch away from poetry to uv.

In the PR's current form, contributors will have to explicitly add samples to this list, at least if they are adding tests or something else that needs to import the sample package. I haven't yet found a way to automatically add top-level directories matching a mattern as packages, but nor have I confirmed that it is impossible. (I believe it's a difference between poetry and uv; the former did this automatically, and the latter perhaps views that as unprincipled.)

[tool.hatch.build.targets.wheel]
include = ["./**/*.py"]
packages = [
    "activity_worker",
    "bedrock",
    "cloud_export_to_parquet",
    "context_propagation",
    "custom_converter",
    "custom_decorator",
    "dsl",
    "encryption",
    "gevent_async",
    "hello",
    "langchain",
    "message_passing",
    "open_telemetry",
    "patching",
    "polling",
    "prometheus",
    "pydantic_converter",
    "pydantic_converter_v1",
    "pyproject.toml",
    "replay",
    "schedules",
    "sentry",
    "sleep_for_days",
    "tests",
    "trio_async",
    "updatable_timer",
    "worker_specific_task_queues",
    "worker_versioning",
]

This reverts commit 44bf6f3.

Locking dependencies with "uv lock"... Using CPython 3.13.1 × No solution found when resolving dependencies for split (python_full_version >= '3.12'): ╰─▶ Because sentry-sdk==1.45.1 depends on urllib3==1.26.20 and urllib3==2.3.0, we can conclude that sentry-sdk==1.45.1 cannot be used. And because temporalio-samples:sentry depends on sentry-sdk==1.45.1 and your project requires temporalio-samples:sentry, we can conclude that your project's requirements are unsatisfiable. warning: An error occurred when locking dependencies, so "uv.lock" was not created. Locking dependencies with "uv lock" again to remove constraints... Using CPython 3.13.1 Resolved 113 packages in 44ms Successfully migrated project from Poetry to uv!

pyarrow install is failing

This reverts commit e7b3794.

Copilot

Pull Request Overview

This PR migrates the project from using Poetry to using uv for dependency management and workflow execution. The key changes include:

Updating run commands in README files from “poetry run” to “uv run” or “uv sync”.
Adjusting CI configuration to use uv and its tooling.
Wrapping the result from chain.ainvoke in langchain activities in a dict.

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
message_passing/*/README.md	Updated commands to use uv instead of poetry
langchain/activities.py	Changed return statement to wrap async result in a dict
langchain/README.md, others	Updated sample instructions to reflect the uv commands
.github/workflows/ci.yml	Updated CI configuration to install and sync using uv
cloud_export_to_parquet/README.md	Updated dependency sync command with a modified group flag

Comments suppressed due to low confidence (2)

langchain/activities.py:29

Verify that wrapping the result of chain.ainvoke in a dict constructor is necessary; if chain.ainvoke already returns a dictionary, this extra conversion might be redundant or potentially introduce unexpected behavior.

return dict(

cloud_export_to_parquet/README.md:7

[nitpick] Ensure consistency in group naming conventions; confirm whether the identifier should use dashes or underscores across the project.

uv sync --group=cloud-export-to-parquet

dandavison · 2025-04-02T10:28:58Z

Ensure consistency in group naming conventions; confirm whether the identifier should use dashes or underscores across the project.

@copilot see 7bfe1d7. I believe dashes and underscores can be used interchangeably in group names, although a relevant uv bug was recently fixed: astral-sh/uv#12585. I propose using dashes here: it makes it clear to the reader that what they're looking at are not package names.

cretz · 2025-04-02T16:48:00Z

README.md


 ## Usage

 Prerequisites:

-* Python >= 3.9


Can we leave the Python version constraints?

We don't want users thinking they have to install a special Python version. uv users should install python using

uv python install 3.9

Happy to clarify somewhere that they should run that command.

We don't want users thinking they have to install a special Python version. uv users should install python using

Right, "Python >= 3.9" just means "the software in this repository needs at least Python 3.9", it doesn't say how to install it or that it has to be any specific version. Our SDK and samples repo READMEs need to clarify which versions of Python they work with.

How about this? c99cefe

cretz · 2025-04-02T16:51:28Z

.github/workflows/ci.yml

-      - run: poetry install --with pydantic_converter --with dsl --with encryption --with trio_async
+      - run: uv tool install poethepoet
+      - run: uv sync --group=dsl --group=encryption --group=trio-async --python ${{ matrix.python }}
+      - name: Check python version


Not sure we really need this Python version checker code (or the --python on the uv sync)

Oops yes, removed.

dandavison force-pushed the uv branch 2 times, most recently from 4ebb246 to d4f5714 Compare March 31, 2025 15:50

dandavison marked this pull request as ready for review April 1, 2025 12:03

dandavison added 9 commits April 1, 2025 19:10

uvx migrate-to-uv

2e1101f

Revert "uvx migrate-to-uv"

1d2f792

This reverts commit 44bf6f3.

Update README

716bee0

Make cloud_export_to_parquet non-default

65fdbbd

pyarrow install is failing

remove pyarrow manually and recreate lockfile

e71ae36

Use dashes in group names

7d04187

Add pyarrow back to the group

4f35070

poetry install -> uv sync

041344b

dandavison force-pushed the uv branch 2 times, most recently from 3152c08 to 8c6bcab Compare April 1, 2025 23:11

dandavison added 9 commits April 1, 2025 19:12

rg --json 'poetry run' | rg-replace 'uv run'

867e7fd

poetry install -> uv sync

e0d5a69

Run all executables under uv

3e9417b

Install python on $PATH and check version

5d15e67

Deliberate failure

6c4420f

Don't use uv --preview to install

3652864

Revert "Deliberate failure"

1058734

This reverts commit e7b3794.

Fix type error

7044d9b

Add samples packages explicitly

725f277

dandavison force-pushed the uv branch 3 times, most recently from 8ffa011 to 725f277 Compare April 2, 2025 01:40

dandavison requested review from Copilot and cretz April 2, 2025 10:03

Copilot AI reviewed Apr 2, 2025

View reviewed changes

Use dashes in package names

7bfe1d7

cretz reviewed Apr 2, 2025

View reviewed changes

Remove version sanity check

c9ceb45

dandavison force-pushed the uv branch from 146f72e to c9ceb45 Compare April 2, 2025 16:56

Add Python version and installation instructions

c99cefe

cretz approved these changes Apr 2, 2025

View reviewed changes

rg --json 'uv run python' | rg-replace 'uv run'

f443083

dandavison merged commit 7a1dd4d into main Apr 2, 2025
11 checks passed

dandavison deleted the uv branch April 2, 2025 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to uv #170

Migrate to uv #170

dandavison commented Mar 31, 2025 •

edited

Loading

Copilot AI left a comment

dandavison commented Apr 2, 2025

cretz Apr 2, 2025

dandavison Apr 2, 2025

dandavison Apr 2, 2025

cretz Apr 2, 2025

dandavison Apr 2, 2025 •

edited

Loading

cretz Apr 2, 2025

cretz Apr 2, 2025

dandavison Apr 2, 2025

Migrate to uv #170

Migrate to uv #170

Conversation

dandavison commented Mar 31, 2025 • edited Loading

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

dandavison commented Apr 2, 2025

cretz Apr 2, 2025

Choose a reason for hiding this comment

dandavison Apr 2, 2025

Choose a reason for hiding this comment

dandavison Apr 2, 2025

Choose a reason for hiding this comment

cretz Apr 2, 2025

Choose a reason for hiding this comment

dandavison Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

cretz Apr 2, 2025

Choose a reason for hiding this comment

cretz Apr 2, 2025

Choose a reason for hiding this comment

dandavison Apr 2, 2025

Choose a reason for hiding this comment

dandavison commented Mar 31, 2025 •

edited

Loading

dandavison Apr 2, 2025 •

edited

Loading