Merged
Conversation
cretz
reviewed
Jul 25, 2025
cretz
reviewed
Jul 25, 2025
Contributor
cretz
left a comment
There was a problem hiding this comment.
Looking good, only minor things. Would be nice if there was a test to ensure this sample keeps working, but not technically required.
Contributor
Author
added a test :) |
Contributor
Missing a push? |
Contributor
Author
yup 🙃 sorry |
cretz
approved these changes
Jul 25, 2025
| def test_workflow_completes_after_polling | ||
| task_queue = "tq-#{SecureRandom.uuid}" | ||
|
|
||
| Temporalio::Testing::WorkflowEnvironment.start_time_skipping do |env| |
Contributor
There was a problem hiding this comment.
Not sure if all environments will support time skipping. In our Ruby SDK base Test class we have:
def skip_if_not_x86!
skip('Test only supported on x86') unless RbConfig::CONFIG['host_cpu'] == 'x86_64'
end
And we invoke that at the top of any test that needs time skipping. May want to do the same here.
Contributor
Author
There was a problem hiding this comment.
added to the best test.rb file that the tests inherit from, added to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added infrequent polling sample that uses BENIGN category for the application failure
Why?
Sample parity + demonstrate usage of BENIGN