Skip to content

Ready: Add Polling Samples #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ready: Add Polling Samples #414

wants to merge 1 commit into from

Conversation

GSmithApps
Copy link
Contributor

@GSmithApps GSmithApps commented Feb 11, 2025 •
edited
Loading

What was changed

  • added samples for
    • infrequent polling
    • frequent polling
  • removed husky from the nextjs ecommerce app
  • added vscode launch.json to gitignore

Why?

DSE Jira Ticket

We can consider this PR finished when we merge this one. Thomas fixed the other parts of it when he merged this

Checklist

  1. How was this tested:
    I ran these two in my local and got expected behavior

  2. Code cleanliness:
    ran linter and formatter ✅

@GSmithApps GSmithApps changed the title Polling Ready: Polling Feb 11, 2025
@GSmithApps GSmithApps marked this pull request as draft February 11, 2025 13:31
@GSmithApps GSmithApps changed the title Ready: Polling Polling Feb 11, 2025
@GSmithApps
Added Polling Samples
8ad6f14 
- added samples for
  - infrequent polling
  - frequent polling
- removed husky from the nextjs ecommerce app
- added vscode launch.json to gitignore

[DSE Jira Ticket](https://temporalio.atlassian.net/browse/DSE-21)

We can consider [this PR](temporalio#410) finished when we merge this one. Thomas fixed the other parts of it when he merged [this](https://github.com/temporalio/samples-typescript/pull/412/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L38)

<!--- add/delete as needed --->

1. How was this tested:
I ran these two in my local and got expected behavior

2. Code cleanliness:
ran linter and formatter ✅
@GSmithApps GSmithApps changed the title Polling Add Polling Samples Feb 11, 2025
@GSmithApps GSmithApps changed the title Add Polling Samples Ready: Add Polling Samples Feb 11, 2025
@GSmithApps GSmithApps marked this pull request as ready for review February 11, 2025 13:54
@GSmithApps
Copy link
Contributor Author

These are failing saying Update your lockfile using "pnpm install --no-frozen-lockfile", but I already did that in my local and pushed. I ran git clean -xfd && rm pnpm-lock.yaml && pnpm install --no-frozen-lockfile

@antmendoza antmendoza requested a review from mjameswh February 11, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjameswh mjameswh Awaiting requested review from mjameswh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GSmithApps