Background heartbeating sample #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjameswh is there any feedback on this or should I close this and put this in my own repo showing common patterns? |
|
Sorry Mike, I have been very busy on other things. Please leave it open here, it is definitely a good fit for this repo. I will try to review sooner than later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows (and tests) how to have a
heartbeatexecuting inside a loop while performing a long running operation inside an Activity.This needs to support
cancellationas well.What was changed
Extended the
heartbeatdemonstration with a realistic long-running activity impl that needs to kick of both a periodic heartbeat and a long-running, blocking process inside an Activity.For example, writing to a file might take a loooong time but I want to ping the Temporal service in the background while my sync file operation is doing it's thing.
Why?
It should make clearer how to get these concurrent things working together.
Checklist
How was this tested:
mochaunit tests. Also verified cancellation works like I'd expect.Any docs updates needed? Not really