Add testing helper to safe message handlers sample#423
Merged
yuandrew merged 3 commits intotemporalio:mainfrom Jun 30, 2025
Merged
Add testing helper to safe message handlers sample#423yuandrew merged 3 commits intotemporalio:mainfrom
yuandrew merged 3 commits intotemporalio:mainfrom
Conversation
dandavison
reviewed
Jun 24, 2025
| state: ClusterManagerState; | ||
| seenJobs: Set<string>; | ||
| nodesMutex: Mutex; | ||
| private maxHistoryLength: number | null; |
Contributor
There was a problem hiding this comment.
I think maxHistoryLength: number? would be appropriate rather than | null?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, clearly someone who's not the most familiar with TS writing TS (I also blame cursor 😊)
yuandrew
force-pushed
the
safe-message-maxHistoryLength
branch
from
5af7fa5 to
427630a
Compare
THardy98
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
maxHistoryLengthto safe message handlers sampleWhy?
All of the other SDK samples have this and new docs point to it, we want this for consistency.
Checklist
Closes
How was this tested: