Skip to content

fix: encode ActivityOptions.summary as json/plain payload#1129

Open
thejens wants to merge 1 commit intotemporalio:masterfrom
thejens:jens/summary
Open

fix: encode ActivityOptions.summary as json/plain payload#1129
thejens wants to merge 1 commit intotemporalio:masterfrom
thejens:jens/summary

Conversation

@thejens
Copy link
Copy Markdown

@thejens thejens commented Feb 23, 2026

What was changed

ActivityOptions::into_command now encodes the summary field using as_json_payload() (json/plain encoding) instead of .into() (binary/plain encoding).

Why?

LocalActivityOptions::into_command (same file, line ~203) already encodes its summary via as_json_payload(). The ActivityOptions path used .into() which produces a binary/plain payload — the Temporal UI cannot decode this and shows "Decoding failed" instead of the summary text.

Checklist

  1. Closes — no existing issue

  2. How was this tested: built and ran locally, see screenshots:

Before:

image

After:

image
  1. Any docs updates needed? No

The LocalActivityOptions path already does this correctly — this just
   aligns the two.
@thejens thejens requested a review from a team as a code owner February 23, 2026 19:57
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Sushisource
Copy link
Copy Markdown
Member

Thanks! We actually need to get the user's data converter all the way in here... as_json_payload should actually go away eventually.

So probably we'll just need to do that properly before the next release. If you're interested in updating the PR to try to do it that way, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants