fix: encode ActivityOptions.summary as json/plain payload#1129
Open
thejens wants to merge 1 commit intotemporalio:masterfrom
Open
fix: encode ActivityOptions.summary as json/plain payload#1129thejens wants to merge 1 commit intotemporalio:masterfrom
thejens wants to merge 1 commit intotemporalio:masterfrom
Conversation
The LocalActivityOptions path already does this correctly — this just aligns the two.
|
|
Member
|
Thanks! We actually need to get the user's data converter all the way in here... So probably we'll just need to do that properly before the next release. If you're interested in updating the PR to try to do it that way, please do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ActivityOptions::into_commandnow encodes thesummaryfield usingas_json_payload()(json/plainencoding) instead of.into()(binary/plainencoding).Why?
LocalActivityOptions::into_command(same file, line ~203) already encodes its summary viaas_json_payload(). TheActivityOptionspath used.into()which produces abinary/plainpayload — the Temporal UI cannot decode this and shows "Decoding failed" instead of the summary text.Checklist
Closes — no existing issue
How was this tested: built and ran locally, see screenshots:
Before:
After: