fix(core): avoid panic when workflow channels close#1165
Open
sachinsharma3191 wants to merge 6 commits intotemporalio:masterfrom
Open
fix(core): avoid panic when workflow channels close#1165sachinsharma3191 wants to merge 6 commits intotemporalio:masterfrom
sachinsharma3191 wants to merge 6 commits intotemporalio:masterfrom
Conversation
chris-olszewski
requested changes
Mar 18, 2026
Member
There was a problem hiding this comment.
We do not want to ignore cases where receivers get dropped unexpectedly. This is unexpected behavior and should result in a panic.
Were you encountering these panics in your own code? If so, please open an issue.
Ah, I see the branch references #692. I think we can solve this more gracefully than just ignoring unexpected receiver drops.Ah, I see the branch references #692. I think we can solve this more gracefully than just ignoring unexpected receiver drops.
6405b52 to
86941ab
Compare
Handle dropped activation/fetch channels in workflow processing without panicking, and add regression tests for channel-drop forwarding behavior.
86941ab to
9c4e57a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test -p temporalio-sdk-core forwarding_output_stops_when_activation_channel_dropped -- --nocapturecargo test -p temporalio-sdk-core forwarding_output_succeeds_with_live_channels -- --nocapturecargo test -p temporalio-sdk-core core_tests::workers::worker_can_shutdown_after_never_polling_ok -- --nocapturecargo test -p temporalio-sdk-core core_tests::workers::shutdown -- --nocapturecargo fmt --all --check