Conversation
|
|
|
@cretz Do you remind spending some time to have a look on this PR 😄 |
| } | ||
|
|
||
| // safeAsDuration ensures that a nil proto duration makes `AsDuration()` return 0. | ||
| func safeAsDuration(duration *durationpb.Duration) time.Duration { |
There was a problem hiding this comment.
Why was this added? .AsDuration() should already be safe for nil
There was a problem hiding this comment.
Why was this added?
.AsDuration()should already be safe for nil
thanks for review, I will check this soon
There was a problem hiding this comment.
Why was this added?
.AsDuration()should already be safe for nil
.AsDuration is a func on *durationpb.Duration, and will panic if call it from nil varible, so it is like the .AsTime
There was a problem hiding this comment.
and will panic if call it from nil varible,
That is not true
var d *durationpb.Duration
fmt.Println(d.AsDuration())
prints 0s
so it is like the .AsTime
That is also not true
There was a problem hiding this comment.
and will panic if call it from nil varible,
That is not true
var d *durationpb.Duration fmt.Println(d.AsDuration())prints 0s
so it is like the .AsTime
That is also not true
It is my mistake! And I removed the safeAsDuration, please have a review again
|
@Quinn-With-Two-Ns any other question？ |
3 participants
Completely fix #1846