Move Nexus operation token generation outside of callback conditional#2009
Merged
Move Nexus operation token generation outside of callback conditional#2009
Conversation
bergundy
approved these changes
Jul 31, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Thanks! No reason why the code was in the conditional.
Quinn-With-Two-Ns
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Moved Nexus operation token generation outside the conditional the checks whether a callback URL has been set.
Why?
Callbacks are optional in the Nexus protocol and many non-workflow callers will start operations without them but still need to get the operation token.