Skip to content

Cleanup nightly tps workflow#2091

Merged
THardy98 merged 4 commits intomasterfrom
cleanup-nightly-tps-workflow
Oct 30, 2025
Merged

Cleanup nightly tps workflow#2091
THardy98 merged 4 commits intomasterfrom
cleanup-nightly-tps-workflow

Conversation

@THardy98
Copy link
Copy Markdown
Contributor

@THardy98 THardy98 commented Oct 25, 2025

What was changed

cleanup:

  • change defaults (shouldn't matter because repo variables control this)
  • remove redundant final step
  • remove unnecessary SCENARIO_EXIT_CODE
  • added permissions block
  • added repo name to slack alert

Why?

tidiness

…iables control this), remove redundant final step, remove unnecessary SCENARIO_EXIT_CODE
Comment thread .github/workflows/nightly-throughput-stress.yml Outdated
@THardy98 THardy98 marked this pull request as ready for review October 29, 2025 17:29
@THardy98 THardy98 requested a review from a team as a code owner October 29, 2025 17:29
push:
branches:
- add-nightly-throughput-stress-workflow
- cleanup-nightly-tps-workflow
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove this manual branch?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep until this is merged, so i can get a few test runs in (just in case)

@THardy98 THardy98 merged commit 82be7bc into master Oct 30, 2025
29 of 31 checks passed
@THardy98 THardy98 deleted the cleanup-nightly-tps-workflow branch October 30, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants