Skip to content

Add support for Stand Alone Nexus Operations#2280

Open
Quinn-With-Two-Ns wants to merge 4 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:NEXUS-289
Open

Add support for Stand Alone Nexus Operations#2280
Quinn-With-Two-Ns wants to merge 4 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:NEXUS-289

Conversation

@Quinn-With-Two-Ns
Copy link
Copy Markdown
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Apr 8, 2026

NOTE FOR REVIEWERS: This PR is pending the actual release of the API and Server and will not be merged until those are complete.

Add standalone Nexus operation support

Adds the ability to start, poll, describe, cancel, terminate, list, and count Nexus operations directly from the
client, outside of workflow context. This mirrors the standalone activity pattern and is based on the API we already reviewed the cross SDK design for.

API

  • client.NewNexusClient(options) — creates a NexusClient bound to an endpoint+service
  • NexusClient.ExecuteOperation(ctx, operation, input, options) — starts an operation and returns a handle
  • NexusOperationHandle.GetID() / GetRunID() / Get() / Describe() / Cancel() / Terminate() — handle operations
  • client.GetNexusOperationHandle(options) — creates a handle to an existing operation (no network call)
  • client.ListNexusOperations(ctx, options) — lists operations via visibility query
  • client.CountNexusOperations(ctx, options) — counts operations via visibility query

Interceptor support

Adds 6 methods to ClientOutboundInterceptor: ExecuteNexusOperation, GetNexusOperationHandle, CancelNexusOperation,
TerminateNexusOperation, DescribeNexusOperation, PollNexusOperationResult. List and Count bypass the interceptor,
consistent with standalone activities.

Testing

  • Unit tests for interceptor header propagation, client validation, and operation name resolution
  • Integration tests covering execute+get, describe, get handle, cancel, terminate, list, count, and validation

Note

Medium Risk
Adds new experimental client APIs and interceptor surface for starting/managing Nexus operations, touching core client plumbing and gRPC calls. Risk is mitigated by being additive/experimental, but it expands public interfaces and integration behavior.

Overview
Adds experimental standalone Nexus operation APIs to client.Client, including NewNexusClient, ExecuteOperation, operation handles (Get/Describe/Cancel/Terminate), and visibility helpers ListNexusOperations/CountNexusOperations.

Extends the client interceptor API with Nexus operation hooks (execute/get-handle/poll/describe/cancel/terminate) and implements the underlying gRPC wiring plus option/metadata types in a new internal/internal_nexus_client.go with unit/integration coverage.

Updates CI to disable the new standalone Nexus integration suite by default (DISABLE_STANDALONE_NEXUS_TESTS) and bumps go.temporal.io/api across modules to a newer pre-release commit needed for the new Nexus RPCs.

Reviewed by Cursor Bugbot for commit d296109. Bugbot is set up for automated code reviews on this repo. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review April 8, 2026 17:16
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner April 8, 2026 17:16
Comment thread mocks/Client.go
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fe42e708a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +33
// ID - The business identifier of the operation.
//
// Mandatory: No default.
ID string
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename start option field to OperationID for API consistency

ClientStartNexusOperationOptions introduces an ID field while the rest of the new Nexus API uses OperationID (GetNexusOperationHandleOptions, metadata structs, and the integration test callsites). This inconsistency makes normal usage patterns fail at compile time (unknown field OperationID) and effectively breaks the newly added standalone Nexus start API for callers who follow the surrounding API naming. Aligning this field name now avoids shipping an immediately incompatible public surface.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to be consistent with Stand alone activities naming approach

Comment thread internal/internal_nexus_client.go
Comment thread internal/internal_nexus_client.go
Comment thread internal/internal_nexus_client.go
Comment thread internal/internal_nexus_client.go
Comment thread internal/internal_nexus_client.go
Comment thread mocks/Client.go Outdated
Comment thread client/client.go
Comment thread internal/internal_nexus_client.go
Comment thread client/client.go Outdated
Comment thread internal/internal_nexus_client_test.go
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit d296109. Configure here.

}
if resp.Result != nil {
if valuePtr == nil {
return nil
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get skips caching result when valuePtr is nil

Medium Severity

In clientNexusOperationHandleImpl.Get, when valuePtr is nil and the poll returns a successful result, the method returns nil without caching the result in h.result. Subsequent calls to Get with a non-nil valuePtr will re-poll the server unnecessarily. The h.result assignment needs to happen before the valuePtr == nil early return, consistent with how the error path always caches before returning.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d296109. Configure here.

Comment thread test/integration_test.go
defer cancel()

// Create a Nexus endpoint targeting our task queue.
endpoint := "sdk-go-nexus-standalone-test-ep-" + uuid.NewString()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the endpoint be deleted at the end of the test? Maybe a deferred deletion?

Comment thread test/integration_test.go
ts.NoError(err)

// Get a handle to the same operation.
handle2 := ts.client.GetNexusOperationHandle(client.GetNexusOperationHandleOptions{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test where the run ID is not specified.

@Quinn-With-Two-Ns
Copy link
Copy Markdown
Contributor Author

Note this PR is missing support for otel I was planning on addressing that in a separate PR to keep the scope down

@chrsmith chrsmith self-assigned this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants