Skip to content

Port system Nexus envelope encoding rewrite#2293

Draft
tconley1428 wants to merge 10 commits intomainfrom
encoding_code_gen
Draft

Port system Nexus envelope encoding rewrite#2293
tconley1428 wants to merge 10 commits intomainfrom
encoding_code_gen

Conversation

@tconley1428
Copy link
Copy Markdown

Summary

  • port the Python SDK system Nexus envelope handling to the Go SDK
  • keep the outer SignalWithStartWorkflowExecution system envelope unencoded while rewriting nested user payloads through codec and external storage
  • add unit and integration coverage for the new rewrite path

Testing

  • GOCACHE=/tmp/temporal-sdk-go-cache go test ./internal -run TestSystemNexusOutboundPayloadVisitor_RewritesNestedPayloadsOnly -count=1
  • GOCACHE=/tmp/temporal-sdk-go-cache go test ./internal -run TestDoesNotExist
  • GOCACHE=/tmp/temporal-sdk-go-cache go test ./temporalnexus/system -run TestDoesNotExist
  • GOCACHE=/tmp/temporal-sdk-go-cache go test . -run TestSystemNexusDefersOuterEnvelopeEncoding -count=1

Comment thread internal/workflow.go
}

payload, err := dc.ToPayload(input.Input)
payloadConverter := dc
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't really a payload converter in all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant