Add CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_USE_RAMPING_VERSION#2319
Add CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_USE_RAMPING_VERSION#2319
CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_USE_RAMPING_VERSION#2319Conversation
…ped CLI dep to support use ramping version on CaN
752ae85 to
7c0781d
Compare
| ContinueAsNewVersioningBehaviorAutoUpgrade = 1 | ||
|
|
||
| // ContinueAsNewVersioningBehaviorUseRampingVersion - Use the Ramping Version of the workflow's task queue at start time, | ||
| // regardless of the workflow's Target Version (according to f(workflow_id, ramp_percentage)). After the first workflow |
There was a problem hiding this comment.
instead of f(workflow_id, ramp_percentage), should we say something along the lines of:
// The Target Version is chosen with the default formula:
// if calcRampThreshold(workflow_id) <= ramp_percentage:
// target=ramping_version
// else:
// target=current_version
I feel like f(workflow_id, ramp_percentage) will invite lots of questions.
I am ok being transparent about this formula -- we won't change it by default after GA because that could cause workflows to "roll back" accidentally, even with same ramp percentage
There was a problem hiding this comment.
calcRampThreshold is the name of the server function we actually use, so people (or claude) can look it up if they're interested
There was a problem hiding this comment.
I'm going to remove it entirely, I don't think we need to leak server versioning internals here (I also don't anticipate people finding this particularly necessary)
There was a problem hiding this comment.
We define Ramping, Current, and Target version here fwiw https://docs.temporal.io/worker-versioning#versioning-definitions fwiw, so people can look those up there
d9f4505 to
9ac729e
Compare
What was changed
DWISOTT - adds
UseRampingVersionas a CaN versioning optionWhy?
support new versioning option
Part of Expose
CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_USE_RAMPING_VERSIONin SDKs features#807How was this tested:
Added integration tests
Any docs updates needed?
Maybe ?