Skip to content

Remove dead links #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuandrew wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead links #2322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,6 @@ func (ts *IntegrationTestSuite) TestBasic() {
err := ts.executeWorkflow("test-basic", ts.workflows.Basic, &expected)
ts.NoError(err)
ts.EqualValues(expected, ts.activities.invoked())
// See https://grokbase.com/p/gg/golang-nuts/153jjj8dgg/go-nuts-fm-suffix-in-function-name-what-does-it-mean
// for explanation of -fm postfix.
ts.Equal([]string{"Go", "ExecuteWorkflow begin", "ExecuteActivity", "ExecuteActivity", "ExecuteWorkflow end"},
ts.tracer.GetTrace("Basic"))

Expand Down
4 changes: 2 additions & 2 deletions worker/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,15 @@ type (

// ReplayWorkflowHistoryFromJSONFile executes a single workflow task for the json history file downloaded from the cli.
// To download the history file: temporal workflow show --workflow-id <workflow_id> --output json > <output_file>
// See https://github.com/temporalio/temporal/blob/master/tools/cli/README.md for full documentation
// See https://docs.temporal.io/cli and https://github.com/temporalio/cli for full documentation.
// Use for testing the backwards compatibility of code changes and troubleshooting workflows in a debugger.
// The logger is an optional parameter. Defaults to the noop logger.
ReplayWorkflowHistoryFromJSONFile(logger log.Logger, jsonfileName string) error

// ReplayPartialWorkflowHistoryFromJSONFile executes a single workflow task for the json history file upto provided
// lastEventID(inclusive), downloaded from the cli.
// To download the history file: temporal workflow show --workflow-id <workflow_id> --output json > <output_file>
// See https://github.com/temporalio/temporal/blob/master/tools/cli/README.md for full documentation
// See https://docs.temporal.io/cli and https://github.com/temporalio/cli for full documentation.
// Use for testing the backwards compatibility of code changes and troubleshooting workflows in a debugger.
// The logger is an optional parameter. Defaults to the noop logger.
ReplayPartialWorkflowHistoryFromJSONFile(logger log.Logger, jsonfileName string, lastEventID int64) error
Expand Down
Loading