fix: handle nil payloads in composite converter#422
Merged
chris-olszewski merged 4 commits intomainfrom Apr 22, 2026
Merged
Conversation
357d7c9 to
45f2c08
Compare
cconstable
reviewed
Apr 22, 2026
|
|
||
| # For API key tests | ||
| TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-west-2.aws.api.temporal.io:7233 | ||
| TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-east-1.aws.api.temporal.io:7233 |
Sushisource
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
nilbefore attempting to convert it.untyped.Why?
Go SDK produced workflow and activity completions can be missing the
resultfield if they did not produce a result. This differs from other SDKs (e.g. Ruby) where a payload withbinary/nullencoding is emitted.Checklist
Closes [Bug] Executing Child Workflow in Go SDK which has no result crashes worker tasks with "NoMethodError: undefined method 'metadata' for nil" #421
How was this tested:
First commit adds failing tests including integration test that uses a Go workflow/activity to verify that Go SDK does return result with a missing
resultfield.Any docs updates needed?
N/A