Skip to content

fix: handle nil payloads in composite converter#422

Merged
chris-olszewski merged 4 commits intomainfrom
olszewski/fix_gh_421
Apr 22, 2026
Merged

fix: handle nil payloads in composite converter#422
chris-olszewski merged 4 commits intomainfrom
olszewski/fix_gh_421

Conversation

@chris-olszewski
Copy link
Copy Markdown
Member

What was changed

  • Now check if the payload is nil before attempting to convert it.
  • After chore: generate protobuf rbs #414 we now better typing around our Protobuf messages so we can tighten some of the RBS types. I was hoping this would display the bug as a type error, but it appears the generated RBS types are not honest enough where that happens. Kept the RBS updates as they are still strictly more correct than untyped.

Why?

Go SDK produced workflow and activity completions can be missing the result field if they did not produce a result. This differs from other SDKs (e.g. Ruby) where a payload with binary/null encoding is emitted.

Checklist

  1. Closes [Bug] Executing Child Workflow in Go SDK which has no result crashes worker tasks with "NoMethodError: undefined method 'metadata' for nil" #421

  2. How was this tested:
    First commit adds failing tests including integration test that uses a Go workflow/activity to verify that Go SDK does return result with a missing result field.

  3. Any docs updates needed?
    N/A

@chris-olszewski chris-olszewski requested a review from a team as a code owner April 22, 2026 15:49
Comment thread .github/workflows/ci.yml

# For API key tests
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-west-2.aws.api.temporal.io:7233
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-east-1.aws.api.temporal.io:7233
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why was this needed?

@chris-olszewski chris-olszewski merged commit f61c70d into main Apr 22, 2026
7 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_gh_421 branch April 22, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Executing Child Workflow in Go SDK which has no result crashes worker tasks with "NoMethodError: undefined method 'metadata' for nil"

3 participants