Static C bridge support#1008
Merged
cretz merged 2 commits intotemporalio:masterfrom Sep 11, 2025
Merged
Conversation
Sushisource
reviewed
Sep 11, 2025
Comment on lines
+202
to
+213
| run: | | ||
| cat > test.c <<'EOF' | ||
| #include "temporal-sdk-core-c-bridge.h" | ||
| #include <stdio.h> | ||
|
|
||
| int main(void) { | ||
| struct TemporalCoreCancellationToken *tok = temporal_core_cancellation_token_new(); | ||
| temporal_core_cancellation_token_free(tok); | ||
| printf("C bridge static link test passed!\\n"); | ||
| return 0; | ||
| } | ||
| EOF |
Member
There was a problem hiding this comment.
I'd rather have this not inline in the workflow. We can just put it in tests/
Contributor
Author
There was a problem hiding this comment.
I will move it there, it just never really runs there and requires certain gcc setup and such, but no prob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
xz2-staticfeature to core-bridgeziplibrary to remove some features we don't care about to make sure it can workChecklist