Make sure legacy queries are failed if gRPC message too large#1206
Merged
Sushisource merged 3 commits intomasterfrom Apr 9, 2026
Merged
Make sure legacy queries are failed if gRPC message too large#1206Sushisource merged 3 commits intomasterfrom
Sushisource merged 3 commits intomasterfrom
Conversation
Sushisource
force-pushed
the
grpc-too-large-query
branch
from
68c9bcf to
f97969b
Compare
Sushisource
force-pushed
the
grpc-too-large-query
branch
from
f97969b to
7ef5380
Compare
chris-olszewski
approved these changes
Apr 8, 2026
| BARR.wait().await; | ||
| // Poke the workflow off the sticky queue to get it to complete faster than WFT timeout | ||
| WorkflowService::reset_sticky_task_queue( | ||
| let _ = WorkflowService::reset_sticky_task_queue( |
Member
There was a problem hiding this comment.
Does this grpc request fail now?
Member
Author
There was a problem hiding this comment.
It could've always failed, it fails if the workflow is already closed (which, IMO, is weird, but whatever). Safe to ignore.
Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
See title
Why?
Client gets to see a clear explicit failure message rather than a timeout
Checklist
Closes [Bug] Report gRPC-message-size-too-large error to server when sending WFT failures and query results #970
How was this tested:
New UT
Any docs updates needed?