feat(sdk): add typed continue as new#1209
Merged
chris-olszewski merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
Sushisource
approved these changes
Apr 10, 2026
| &self, | ||
| input: &<W::Run as WorkflowDefinition>::Input, | ||
| opts: ContinueAsNewOptions, | ||
| ) -> Result<std::convert::Infallible, WorkflowTermination> |
Member
There was a problem hiding this comment.
Fun to see Infallible in the OK spot
| }, | ||
| )) | ||
| ctx.continue_as_new(&(), ContinueAsNewOptions::default())?; | ||
| Ok(()) |
Member
There was a problem hiding this comment.
Will the compiler let you remove the Ok(()) here because the OK path of CaN is infallible?
Alternatively, writing the can call without the ? as the final statement would make sense to me here
chris-olszewski
force-pushed
the
olszewski/feat_continue_as_new
branch
from
274988a to
a94ece4
Compare
chris-olszewski
force-pushed
the
olszewski/feat_continue_as_new
branch
from
a94ece4 to
f5841e3
Compare
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
continue_as_newhelper method to workflow context.Why?
More ergonomic and enforces correct input type for the workflow.
Checklist
Closes N/A
How was this tested:
Added small unit tests to verify serialization error gets populated and input threaded through. Updated existing integration tests to use helper method.
Any docs updates needed?
Updated READMEs