Add DNS load balancing#1212
Merged
Sushisource merged 3 commits intomasterfrom Apr 15, 2026
Merged
Conversation
chris-olszewski
requested changes
Apr 14, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Example failures are real. I think we should disable DNS load balancing if the host is localhost.
Member
Author
Yeah, we probably should. I fixed it in a few places but it requires whatever's serving on localhost to bind properly which users may not do. |
chris-olszewski
approved these changes
Apr 14, 2026
Sushisource
force-pushed
the
dns-load-balance
branch
from
33efcce to
d769f8a
Compare
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
Matches behavior of Go & Java, theoretically improves availability.
Checklist
Closes
How was this tested:
Added some unit tests, virtually all existing tests run through this right now anyway, importantly including cloud tests.
Any docs updates needed?