Shutdown rpc initiate shutdown#1224
Merged
Sushisource merged 18 commits intomasterfrom Apr 23, 2026
Merged
Conversation
Sushisource
force-pushed
the
shutdown-rpc-initiate-shutdown
branch
2 times, most recently
from
b1c7dcf to
8ad3510
Compare
…me timeout to avoid race
Sushisource
force-pushed
the
shutdown-rpc-initiate-shutdown
branch
from
2842753 to
022f739
Compare
chris-olszewski
approved these changes
Apr 23, 2026
Comment on lines
+1218
to
+1226
| use std::sync::{ | ||
| Arc, | ||
| atomic::{AtomicBool, Ordering}, | ||
| }; | ||
| use temporalio_common::protos::temporal::api::{ | ||
| namespace::v1::{NamespaceInfo, namespace_info::Capabilities}, | ||
| workflowservice::v1::DescribeNamespaceResponse, | ||
| }; | ||
| use tokio::sync::Notify; |
Member
There was a problem hiding this comment.
Can move these imports up to test module level
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening #1197
On a non-fork branch to be able to run Cloud tests