Fix NDE when multiple patches in a single WFT exceed SA's 2048-byte limit#1225
Merged
Fix NDE when multiple patches in a single WFT exceed SA's 2048-byte limit#1225
Conversation
chris-olszewski
approved these changes
Apr 21, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On replay, when emitting the
TemporalChangeVersionsearch attributes following emitting patch marker, we would previously include all known patches, including those that had been looked ahead but not yet emitted by the workflow code.That could result in situations where we'd hit the SA's 2048 bytes size limit earlier in replay if 1) multiple patches were emitted during a single WFT, and 2) the SA's 2048 bytes limit was reached during that WFT. That situation would surface as an NDE, as the original execution would have emitted an
UpseartSearchAttributecommand for the first few patches, only stopping once the cumulative length of patches would exceed the limit, while on replay, there would be noUpseartSearchAttributecommand at all.This PR change the Patch->UpseartSearchAttribute handling to only include patches that the workflow has effectively emitted so far (
created_command == true).Fixes #1223.