Skip to content

Set WFT Failed cause on grpc message too large incidents #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sushisource merged 1 commit into from
Apr 22, 2026
Merged

Set WFT Failed cause on grpc message too large incidents #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/sdk-core/src/core_tests/queries.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ async fn legacy_query_too_large_responds_with_failure() {
assert!(
matches!(&result, LegacyQueryResult::Failed(f) if
f.failure.as_ref().unwrap().message == "GRPC Message too large"
&& f.force_cause() == WorkflowTaskFailedCause::GrpcMessageTooLarge
),
"Expected query failure with message-too-large, got: {:?}",
matches!(&result, LegacyQueryResult::Failed(_)),
Expand Down
2 changes: 2 additions & 0 deletions crates/sdk-core/src/core_tests/workflow_tasks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3109,6 +3109,8 @@ async fn grpc_message_too_large_doesnt_spam_task_fails() {
Ok(Default::default())
}
}));
mh.expect_fail_wft_matcher =
Box::new(|_, cause, _| *cause == WorkflowTaskFailedCause::GrpcMessageTooLarge);

let mut mock = build_mock_pollers(mh);
mock.worker_cfg(|wc| wc.max_cached_workflows = 1);
Expand Down
53 changes: 21 additions & 32 deletions crates/sdk-core/src/worker/workflow/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,22 +416,7 @@ impl Workflows {
Err(e)
if e.metadata().contains_key(MESSAGE_TOO_LARGE_KEY) && attempt < 2 =>
{
let failure = Failure {
failure: Some(
temporalio_common::protos::temporal::api::failure::v1::Failure {
message: "GRPC Message too large".to_string(),
failure_info: Some(FailureInfo::ApplicationFailureInfo(
ApplicationFailureInfo {
r#type: "GrpcMessageTooLarge".to_string(),
non_retryable: true,
..Default::default()
},
)),
..Default::default()
},
),
force_cause: 0,
};
let failure = make_grpc_message_too_large_failure();
let new_outcome = FailedActivationWFTReport::Report(
task_token,
WorkflowTaskFailedCause::GrpcMessageTooLarge,
Expand Down Expand Up @@ -860,22 +845,7 @@ impl Workflows {
}
Err(e) if e.metadata().contains_key(MESSAGE_TOO_LARGE_KEY) => {
warn!(error=%e, "Query response too large, responding with failure");
let failure = Failure {
failure: Some(
temporalio_common::protos::temporal::api::failure::v1::Failure {
message: "GRPC Message too large".to_string(),
failure_info: Some(FailureInfo::ApplicationFailureInfo(
ApplicationFailureInfo {
r#type: "GrpcMessageTooLarge".to_string(),
non_retryable: true,
..Default::default()
},
)),
..Default::default()
},
),
force_cause: 0,
};
let failure = make_grpc_message_too_large_failure();
if let Err(e2) = self
.client
.respond_legacy_query(tt, LegacyQueryResult::Failed(failure))
Expand Down Expand Up @@ -1739,6 +1709,25 @@ fn prepare_to_ship_activation(wfa: &mut WorkflowActivation) {
});
}

fn make_grpc_message_too_large_failure() -> Failure {
Failure {
failure: Some(
temporalio_common::protos::temporal::api::failure::v1::Failure {
message: "GRPC Message too large".to_string(),
failure_info: Some(FailureInfo::ApplicationFailureInfo(
ApplicationFailureInfo {
r#type: "GrpcMessageTooLarge".to_string(),
non_retryable: true,
..Default::default()
},
)),
..Default::default()
},
),
force_cause: WorkflowTaskFailedCause::GrpcMessageTooLarge as i32,
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
Loading