chore: feature cleanup#1236
Merged
chris-olszewski merged 4 commits intomainfrom Apr 28, 2026
Merged
Conversation
chris-olszewski
commented
Apr 25, 2026
| "dep:ringbuf", | ||
| "dep:futures-channel", | ||
| ] | ||
| core-telemetry-bridge = ["dep:ringbuf", "dep:futures-channel"] |
Member
Author
There was a problem hiding this comment.
Splitting this out so we can allow Rust SDK users to opt out of prometheus/envconfig
| categories = ["development-tools"] | ||
| exclude = ["machine_coverage/*"] | ||
| rust-version = "1.88.0" # due to cargo msrv find | ||
| # due to cargo msrv find |
Member
Author
There was a problem hiding this comment.
Comment move as my TOML formatter claims that inline # comments should start at column 80 which looks horrible.
|
|
||
| [features] | ||
| default = [] | ||
| antithesis_assertions = ["temporalio-sdk-core/antithesis_assertions"] |
Member
Author
There was a problem hiding this comment.
I didn't see any real reason why this needed to be surfaced to the SDK crate.
chris-olszewski
commented
Apr 26, 2026
|
|
||
| [features] | ||
| history_builders = ["rand"] | ||
| history_builders = ["dep:rand"] |
Member
Author
There was a problem hiding this comment.
P sure dep: prefix is required here
Sushisource
approved these changes
Apr 27, 2026
chris-olszewski
force-pushed
the
olszewski/chore_feature_cleanup
branch
from
822fea8 to
c15897b
Compare
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Make temporalio-sdk feature forwarding explicit so SDK users can opt out of optional lower-level dependencies with
default-features = false. Most of this boiled down to disabling default features when declaring dependencies on in-repo crates.Why?
Give Rust SDK users full control of what underlying features get enabled. Building on top of
core-based-sdkwas too coarse as end users in other languages can't specify Cargo level features as they can in Rust.Checklist
Closes N/A
How was this tested:
CI
Any docs updates needed?
Updated README