Conversation
Sushisource
approved these changes
Apr 29, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Bumped
temporalio/cloud-apiprotos from v0.14.0 to v0.14.0 viagit subtree.Why?
Keep cloud-api in sync.
Checklist
Closes
How was this tested:
cargo check -p temporalio-clientandcargo check -p temporalio-sdk-core-c-bridgeboth compile cleanly (only the expected 2 deprecation warnings on the upstream-deprecated RPCs)cargo test -p temporalio-client --lib -- verify— all 5verify_all_*_service_methods_implementedtests pass, includingverify_all_cloud_service_methods_implementedwhich confirmsALL_IMPLEMENTED_CLOUD_SERVICE_RPCSexactly matches the proto definition (no drift)Any docs updates needed?
Note
Medium Risk
Updates a large set of upstream protobuf definitions and the generated/forwarded client RPC surface, which can cause subtle compatibility issues for Cloud Ops consumers despite being mostly additive.
Overview
Bumps the vendored
api_cloud_upstreamprotos/docs to v0.14.0, adding new Cloud Ops surfaces and versioned field changes.This introduces Custom Roles support end-to-end: new
CloudServiceRPCs (GetCustomRoles,GetCustomRole,CreateCustomRole,UpdateCustomRole,DeleteCustomRole), corresponding request/response messages, and new identity messages (CustomRole,CustomRoleSpec) plusAccountAccess.custom_roles.Namespace protos are extended with replication/fairness constructs (
ReplicaSpec/Replica,FairnessSpec,disable_passive_poller_forwarding) and deprecate older HA region RPCs/fields (AddNamespaceRegion/DeleteNamespaceRegion,NamespaceSpec.regions,Namespace.region_status). The Rust gRPC trait proxy impls are updated to#[allow(deprecated)]so deprecated upstream RPCs remain callable without breaking builds, and the C bridge RPC dispatcher is extended to route the new Custom Role calls.Reviewed by Cursor Bugbot for commit 0c9d5d6. Bugbot is set up for automated code reviews on this repo. Configure here.