Fix missing timeout marker for local activities#919
Closed
yuandrew wants to merge 4 commits intotemporalio:masterfrom
Closed
Fix missing timeout marker for local activities#919yuandrew wants to merge 4 commits intotemporalio:masterfrom
yuandrew wants to merge 4 commits intotemporalio:masterfrom
Conversation
Contributor
Author
|
Fixed up the test setup, now seeing the expected timeout Marker in history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Handle the edge case where the
schedule_to_closetimeout occurs before we've added theTaskTokentooutstanding_activity_tasks.Why?
Antz > Bug's Life
Checklist
Closes [Bug] Missing timeout marker when local activities timeout during worker shutdown #891
How was this tested:
Added test that found the bug