Fix incorrect cgroups memory usage#934
Merged
Sushisource merged 1 commit intomasterfrom Jun 9, 2025
Merged
Conversation
cretz
approved these changes
Jun 9, 2025
| Ordering::Release, | ||
| ); | ||
| } else { | ||
| self.cur_mem_usage.store(mem, Ordering::Release); |
Contributor
There was a problem hiding this comment.
Might as well move let mem = lock.used_memory(); into this conditional too
Sushisource
force-pushed
the
fix-bad-cgroups
branch
from
702b24f to
2c0ddda
Compare
Sushisource
force-pushed
the
fix-bad-cgroups
branch
from
2c0ddda to
c189fab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this obviously wrong calculation.
No specific new tests here b/c this area needs more love in general and should get more tests w/ #903
Fixes #933