Skip to content

Print the last error when failing to connect to ephemeral server #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sushisource merged 2 commits into from
Jun 10, 2025
Merged

Print the last error when failing to connect to ephemeral server #936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73785c
Print the last error when failing to connect to ephemeral server
Sushisource Jun 10, 2025
9b73904
Merge branch 'master' into print-last-ephem-server
Sushisource Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/src/ephemeral_server/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,20 @@ impl EphemeralServer {
.client_name("online-checker".to_owned())
.client_version("0.1.0".to_owned())
.build()?;
let mut last_error = None;
for _ in 0..50 {
sleep(Duration::from_millis(100)).await;
if client_options.connect_no_namespace(None).await.is_ok() {
let connect_res = client_options.connect_no_namespace(None).await;
if let Err(err) = connect_res {
last_error = Some(err);
} else {
return success;
}
}
Err(anyhow!("Failed connecting to test server after 5 seconds"))
Err(anyhow!(
"Failed connecting to test server after 5 seconds, last error: {:?}",
last_error
))
}

/// Shutdown the server (i.e. kill the child process). This does not attempt
Expand Down
Loading