Nexus cancellation type fixes#947
Merged
tconley1428 merged 1 commit intomasterfrom Jun 27, 2025
Merged
Conversation
…en on cancellation failures
Sushisource
approved these changes
Jun 26, 2025
| operation: self.shared_state.operation.clone(), | ||
| operation_id: "".to_string(), | ||
| operation_token: "".to_string(), | ||
| operation_token: operation_token.clone().unwrap_or_default(), |
Member
There was a problem hiding this comment.
Since we have to do this anyway, may as well just not bother with the option and init this to empty string.
Contributor
Author
There was a problem hiding this comment.
I didn't see until after. Care enough to go back for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
WAIT_CANCELLATION_COMPLETED should be default, populate operation_token on cancellation failures
Why?
Default should have the same behavior as before the expansion of cancellation types.
Checklist
Closes
How was this tested:
Tested the change in the python SDK
Any docs updates needed?