fix(client): Properly set temporal-namespace header on gRPC requests #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of #1712 to the 1.11.x branch.
What was changed
Temporal Cloud requires presence of the
temporal-namespacegRPC metadata on every request to the Workflow Service that contains anamespaceproperty. This was not done on the pure-JS Connection. There it is. Fixes [Feature Request] Puttemporal-namespaceheader on all requests from pure JS client #1697.Note that this logic is taken care by Core SDK on
NativeConnection.Also added CI tests against Temporal Cloud. Credentials are provided through environment variables. Tests will be skipped if credentials are missing.