Merged
Conversation
chris-olszewski
approved these changes
Apr 16, 2026
Member
chris-olszewski
left a comment
There was a problem hiding this comment.
What was the reasoning behind the core commit choice?
THardy98
approved these changes
Apr 16, 2026
65c8dd6 to
b5776f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
protobufjsto 7.5.5protobufjs' bug that was causing parse failure on latest Cloud Ops API drop due to addition of protoc-gen-openapiv2 annotations, whichprotobufjsdoesn't support. The fix is implemented using PNPM's patch feature over protobufjs@7.5.4. An upstream ticket will be filed to request a proper fix, but this should be a reasonable solution until then.@temporalio/proto's "runtime root patching" script to make it compatible withprotobufjs7.5.2+ (fix [Bug] Protobuf Payload Converter is broken after upgrading to protobufjs 7.5.2 #1717). See details below.Details on the
protobufjs@7.5.2incompatibilityprotobufjs@7.5.2added a fast-path cache inNamespace#lookup()that accessesthis.root._fullyQualifiedObjects.rootaccessor is defined as a non-enumerable getter onReflectionObject.prototype, so it is not copied byfor...inloops.import * as proto from '@temporalio/proto', TypeScript's__importStarhelper wraps the CJS module in a plain object by iterating own enumerable properties withfor...in+hasOwnProperty.rootis non-enumerable, it is skipped, the wrapper'srootisundefined, and any subsequentthis.root._fullyQualifiedObjectsaccess crashes.rootas an own enumerable getter ensures__importStarincludes it in the wrapper, so thatwrapper.rootdelegates back to the patched root (which has the proper_fullyQualifiedObjectsmap and full prototype chain).