Skip to content

Commit 6a6af68

Browse files
authored
[Merge on 9/18] Remove nexus feature flag (#391)
* Remove nexus feature flag * PR review changes
1 parent 89fff33 commit 6a6af68

2 files changed

Lines changed: 2 additions & 23 deletions

File tree

app/app.go

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,8 @@ func NewApp(params AppParams) (*cli.App, error) {
2727
InsecureConnectionFlag,
2828
EnableDebugLogsFlag,
2929
},
30+
Commands: params.Commands,
3031
}
3132

32-
var commands []*cli.Command
33-
34-
for _, command := range params.Commands {
35-
if command.Name == "nexus" {
36-
if IsFeatureEnabled(NexusFeatureFlag) {
37-
commands = append(commands, command)
38-
}
39-
} else {
40-
commands = append(commands, command)
41-
}
42-
}
43-
app.Commands = commands
44-
4533
return app, nil
4634
}

app/feature.go

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@ import (
1212

1313
var (
1414
GCPSinkFeatureFlag = "enable-gcp-sink"
15-
NexusFeatureFlag = "enable-nexus"
1615
featureflagFileName = "feature.json"
1716
)
1817

19-
var supportFeatureFlags = []string{GCPSinkFeatureFlag, NexusFeatureFlag}
18+
var supportFeatureFlags = []string{GCPSinkFeatureFlag}
2019

2120
type FeatureFlag struct {
2221
Name string `json:"Name"`
@@ -133,14 +132,6 @@ func NewFeatureCommand() (CommandOut, error) {
133132
return toggleFeature(GCPSinkFeatureFlag)
134133
},
135134
},
136-
{
137-
Name: "toggle-nexus",
138-
Aliases: []string{"tnxs"},
139-
Usage: "switch nexus on/off",
140-
Action: func(c *cli.Context) error {
141-
return toggleFeature(NexusFeatureFlag)
142-
},
143-
},
144135
{
145136
Name: "get",
146137
Aliases: []string{"g"},

0 commit comments

Comments
 (0)