Closed
Conversation
alice-yin
reviewed
Jun 5, 2025
| Name: cloudProviderFlagName, | ||
| Aliases: []string{"cp"}, | ||
| Usage: "The cloud provider of the connection, currently only support 'aws' and 'gcp'", | ||
| Required: false, |
Contributor
There was a problem hiding this comment.
This could set as required field?
Contributor
There was a problem hiding this comment.
oh. I see. only neeed for isPrivateFlagName
Contributor
Author
There was a problem hiding this comment.
hmm, currently we allow create public connectivity rule, which doesn't require anything, so we have a validation function to check. The other option is we separate the command to say create-public and create-private
alice-yin
reviewed
Jun 5, 2025
alice-yin
reviewed
Jun 5, 2025
Contributor
alice-yin
left a comment
alice-yin
left a comment
There was a problem hiding this comment.
As this is a pre-release feature, you don't want all people could access this cmd in tcld. What extra you need to add is using IsFeatureEnabled in tcld. You could find some code change around it.
anekkanti
reviewed
Jun 6, 2025
jumbogo
changed the title
This reverts commit e1ccfd8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: