Simplify the removal of all certificates from a namespace#477
Merged
shakeelrao merged 3 commits intomainfrom Sep 22, 2025
Merged
Simplify the removal of all certificates from a namespace#477shakeelrao merged 3 commits intomainfrom
shakeelrao merged 3 commits intomainfrom
Conversation
shakeelrao
changed the title
shakeelrao
changed the title
shakeelrao
changed the title
captainbeardo
approved these changes
Sep 22, 2025
Contributor
captainbeardo
left a comment
captainbeardo
left a comment
There was a problem hiding this comment.
Maybe add some tests?
Contributor
Author
doh! forgot we had unit tests, haha. i did test locally though :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, to remove all certificates from a NS, clients need to export the PEM bundle from the NS and then run:
This flow is slightly tedious, since you often don't know (or care) about the existing certificates when wiping them.
To solve this, this PR introduces a
--allflag to thetcld namespace ca removesubcommand. When provided, the command removes all certificates from the namespace directly: